Bug in Batch Ripper

[Spoon]

Cannot reproduce, there is always a disc number sent through. Even just using 3 providers (discogs, musicbrainz and accuraterip meta).

You could change your naming like:

[IFVALUE][disc],[SETLEN]2,48,,[disc][],01[]

Which would ensure is always 01

[Boffy]

Thanks for looking in to it Spoon.
I’m actually working in br right now.
Some time ago I had the thought that cd ripper per default is setting a cd to 1/1 unless metadata states otherwise. Is that correct?
If so, it seems that br doesn’t read/write this information from cdripper correctly.
I’m curious to what settings you have tested, because I sometimes find it a bit messy that enabled providers in cdripper needs to be enabled by br and vice versa. That might just be me.

The problem persists at my end. With and without internet connection, local data from the disc and online meta alike.
For now I have just replaced setlen disc with 01. That means no multi disc however. I’ll try your naming suggestion. Thanks

[Spoon]

Correct, it looks like CD Ripper fills this in if not present, but batch ripper does not, and I am not wanting to add this to batch ripper because there are checks on missing disc number for triggering the manual input review page and that might stop working.

[Boffy]

Ah I see.
But would it be possible to add a setting in br to check/uncheck?
With multi discs I can live with disc 2’s being incorrectly named 01.
However, right now all discs are named incorrectly.
Then again, your naming syntax might solve this temporarily. Just a suggestion for future development.

[Spoon]

You are best showing the manual metadata review page (always) and setting the disc number if not correct, the online databases cannot be relied upon

[Boffy]

Yeah I know :-) manual review defeats the purpose of batch ripping though. At least for me.